Skip to content

build.yml: Add support for linux-arm64 using linux arm64 hosted runners #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d3m3vilurr merged 2 commits into from
Jan 29, 2025
Merged

build.yml: Add support for linux-arm64 using linux arm64 hosted runners #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b096d2a
build.yml: Add support for linux-arm64 using linux arm64 hosted runners
joel16 Jan 25, 2025
305e21d
build.yml: Update actions/setup-python to v5
joel16 Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 33 additions & 9 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ jobs:
build-linux:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v2
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- name: Install dependencies
run: |
sudo apt-get update
Expand All @@ -27,15 +27,39 @@ jobs:
make -j$(nproc) tarball
- name: Upload artifacts
if: ${{ success() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: vitasdk-linux
path: build/*.tar.bz2
build-linux-arm64:
runs-on: ubuntu-24.04-arm
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- name: Install dependencies
run: |
sudo apt-get update
sudo apt-get install -y software-properties-common
sudo apt-get install -y cmake cmake-data git build-essential autoconf automake libtool texinfo bison flex pkg-config
- name: Build
run: |
git config --global user.email "builds@travis-ci.com"
git config --global user.name "Travis CI"
mkdir build
cd build
cmake ..
make -j$(nproc) tarball
- name: Upload artifacts
if: ${{ success() }}
uses: actions/upload-artifact@v4
with:
name: vitasdk-linux-arm64
path: build/*.tar.bz2
Comment on lines +56 to +57
Copy link
Contributor

@d3m3vilurr d3m3vilurr Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm.... most parts are looks good to me.
just i'm worried that this upload could make trouble in ci chain to detect linux binaries.

https://github.com/vitasdk/vita-headers/blob/master/.travis.d/last_built_toolchain.py

a script doesn't check the arch yet.

Copy link
Contributor

@d3m3vilurr d3m3vilurr Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm... it wouldn't related actual ci chains of other projects... i'll check it

Copy link
Contributor

@d3m3vilurr d3m3vilurr Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual ci is autobuilds's workflow.
this patch would safe. i'll merge it after ci checking of the linux & linux-arm64

Copy link
Contributor Author

@joel16 joel16 Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks!

build-macos:
runs-on: macos-12
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v2
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- name: Build
run: |
git config --global user.email "builds@travis-ci.com"
Expand All @@ -47,7 +71,7 @@ jobs:
make -j$(nproc) tarball
- name: Upload artifacts
if: ${{ success() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: vitasdk-macos
path: build/*.tar.bz2
Expand All @@ -57,8 +81,8 @@ jobs:
# mingw output have to be static linking, and that this reason, we are able to use 22.04 in here
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v2
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- name: Install dependencies
run: |
sudo apt-get update
Expand All @@ -76,7 +100,7 @@ jobs:
make -j$(nproc) tarball
- name: Upload artifacts
if: ${{ success() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: vitasdk-windows
path: build/*.tar.bz2
Loading