Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Jan 21, 2026

No description provided.

@AdamGS AdamGS added do not merge Pull requests that are not intended to merge experiment Tests an idea labels Jan 21, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/experiment-no-sccache branch from 832c391 to 99617e9 Compare January 21, 2026 11:22
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 29.57%

Comparing adamg/experiment-no-sccache (99617e9) with develop (c655272)

Summary

⚡ 3 improved benchmarks
❌ 7 regressed benchmarks
✅ 1244 untouched benchmarks
⏩ 1254 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation encode_varbinview[(1000, 2)] 269.1 µs 242.7 µs +10.87%
Simulation canonical_into_non_nullable[(10000, 100, 0.0)] 1.9 ms 2.7 ms -29.57%
Simulation canonical_into_non_nullable[(10000, 100, 0.01)] 2.1 ms 2.9 ms -27.23%
Simulation canonical_into_nullable[(10000, 10, 0.0)] 530.9 µs 445 µs +19.31%
Simulation canonical_into_non_nullable[(10000, 100, 0.1)] 3.7 ms 4.5 ms -18.04%
Simulation canonical_into_nullable[(10000, 100, 0.0)] 4.9 ms 4.1 ms +19.89%
Simulation into_canonical_non_nullable[(10000, 100, 0.0)] 1.9 ms 2.7 ms -29.53%
Simulation into_canonical_non_nullable[(10000, 100, 0.01)] 2.2 ms 3 ms -26.75%
Simulation into_canonical_non_nullable[(10000, 100, 0.1)] 3.8 ms 4.6 ms -17.65%
Simulation into_canonical_nullable[(10000, 100, 0.0)] 4.4 ms 5.2 ms -15.6%

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AdamGS AdamGS closed this Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Pull requests that are not intended to merge experiment Tests an idea

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants