Skip to content

Experiment with not using sccache for CI #6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdamGS wants to merge 1 commit into from
+44 −44
Closed

Experiment with not using sccache for CI #6070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/setup-rust/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ runs:
shared-key: "rust-cache-${{ github.job }}-${{ runner.environment }}-${{ steps.rust-toolchain.outputs.cachekey }}-${{ inputs.targets }}${{ inputs.cache-suffix && format('-{0}', inputs.cache-suffix) || '' }}"
env-vars: "RUSTFLAGS"

- name: Rust Compile Cache
uses: mozilla-actions/sccache-action@v0.0.9
# - name: Rust Compile Cache
# uses: mozilla-actions/sccache-action@v0.0.9

- name: Install Protoc (for lance-encoding build step)
if: runner.os != 'Windows'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/bench-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ jobs:
steps:
- uses: runs-on/action@v2
if: github.event.pull_request.head.repo.fork == false
with:
sccache: s3
# with:
# sccache: s3
- uses: actions/checkout@v6
with:
ref: ${{ github.event.pull_request.head.sha }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ jobs:
name: Compression
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:
# sccache: s3
- uses: actions/checkout@v6
- uses: ./.github/actions/setup-rust
with:
Expand Down
56 changes: 28 additions & 28 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@
timeout-minutes: 120
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:

Check failure on line 60 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / validate-workflow-yaml 

60:9 [comments-indentation] comment not indented like content
# sccache: s3
- uses: actions/checkout@v6
- uses: ./.github/actions/setup-rust
with:
Expand Down Expand Up @@ -94,8 +94,8 @@
MATURIN_PEP517_ARGS: "--profile dev"
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:

Check failure on line 97 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / validate-workflow-yaml 

97:9 [comments-indentation] comment not indented like content
# sccache: s3
- uses: actions/checkout@v6
- uses: ./.github/actions/setup-rust
with:
Expand Down Expand Up @@ -174,8 +174,8 @@
- tag=rust-docs
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:

Check failure on line 177 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / validate-workflow-yaml 

177:9 [comments-indentation] comment not indented like content
# sccache: s3
- uses: actions/checkout@v6
- uses: ./.github/actions/setup-rust
with:
Expand Down Expand Up @@ -221,8 +221,8 @@
args: "--target wasm32-unknown-unknown --exclude vortex --exclude vortex-cuda --exclude vortex-datafusion --exclude vortex-duckdb --exclude vortex-tui --exclude vortex-zstd"
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:

Check failure on line 224 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / validate-workflow-yaml 

224:9 [comments-indentation] comment not indented like content
# sccache: s3
- uses: actions/checkout@v6
- id: setup-rust
uses: ./.github/actions/setup-rust
Expand Down Expand Up @@ -256,8 +256,8 @@
- tag=rust-min-deps
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:

Check failure on line 259 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / validate-workflow-yaml 

259:9 [comments-indentation] comment not indented like content
# sccache: s3
- uses: actions/checkout@v6
- uses: ./.github/actions/setup-rust
with:
Expand All @@ -278,8 +278,8 @@
- tag=rust-lint
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:

Check failure on line 281 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / validate-workflow-yaml 

281:9 [comments-indentation] comment not indented like content
# sccache: s3
- uses: actions/checkout@v6
- id: setup-rust
uses: ./.github/actions/setup-rust
Expand Down Expand Up @@ -317,8 +317,8 @@
- tag=rust-lint-no-default-${{ matrix.partition }}
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:
# sccache: s3
- uses: actions/checkout@v6
- id: setup-rust
uses: ./.github/actions/setup-rust
Expand Down Expand Up @@ -349,8 +349,8 @@
- tag=rust-semver
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:
# sccache: s3
- uses: actions/checkout@v6
with:
fetch-depth: 0
Expand Down Expand Up @@ -400,8 +400,8 @@
GRCOV_OUTPUT_FILE: "target/coverage/vortex.lcov"
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:
# sccache: s3
- uses: actions/checkout@v6
- id: setup-rust
uses: ./.github/actions/setup-rust
Expand Down Expand Up @@ -474,8 +474,8 @@
VORTEX_SKIP_SLOW_TESTS: "1"
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:
# sccache: s3
- uses: actions/checkout@v6
- name: Install llvm
uses: aminya/setup-cpp@v1
Expand Down Expand Up @@ -536,8 +536,8 @@
runs-on: ${{ matrix.runner }}
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:
# sccache: s3
- uses: actions/checkout@v5
- name: Install Visual Studio Build Tools (Windows)
if: matrix.os == 'windows-x64'
Expand Down Expand Up @@ -583,8 +583,8 @@
timeout-minutes: 120
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:
# sccache: s3
- uses: actions/checkout@v6
- uses: actions/setup-java@v5
with:
Expand Down Expand Up @@ -618,8 +618,8 @@
- tag=bench-codspeed-${{ matrix.shard }}
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:
# sccache: s3
- uses: actions/checkout@v6
- uses: ./.github/actions/setup-rust
with:
Expand Down Expand Up @@ -666,8 +666,8 @@
- tag=cxx-build
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:
# sccache: s3
- uses: actions/checkout@v6
- id: setup-rust
uses: ./.github/actions/setup-rust
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/fuzz.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
artifact_url: ${{ steps.upload_artifacts.outputs.artifact-url }}
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:

Check failure on line 32 in .github/workflows/fuzz.yml

View workflow job for this annotation

GitHub Actions / validate-workflow-yaml 

32:9 [comments-indentation] comment not indented like content
# sccache: s3
- uses: actions/checkout@v6
- uses: ./.github/actions/setup-rust
with:
Expand Down Expand Up @@ -162,8 +162,8 @@
artifact_url: ${{ steps.upload_artifacts.outputs.artifact-url }}
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:

Check failure on line 165 in .github/workflows/fuzz.yml

View workflow job for this annotation

GitHub Actions / validate-workflow-yaml 

165:9 [comments-indentation] comment not indented like content
# sccache: s3
- uses: actions/checkout@v6
- uses: ./.github/actions/setup-rust
with:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/minimize_fuzz_corpus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
- tag=io-fuzz-minimize
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:

Check failure on line 24 in .github/workflows/minimize_fuzz_corpus.yml

View workflow job for this annotation

GitHub Actions / validate-workflow-yaml 

24:9 [comments-indentation] comment not indented like content
# sccache: s3
- uses: actions/checkout@v6
- uses: ./.github/actions/setup-rust
with:
Expand Down Expand Up @@ -68,8 +68,8 @@
- tag=ops-fuzz-minimize
steps:
- uses: runs-on/action@v2
with:
sccache: s3
# with:

Check failure on line 71 in .github/workflows/minimize_fuzz_corpus.yml

View workflow job for this annotation

GitHub Actions / validate-workflow-yaml 

71:9 [comments-indentation] comment not indented like content
# sccache: s3
- uses: actions/checkout@v6
- uses: ./.github/actions/setup-rust
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sql-benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ jobs:
steps:
- uses: runs-on/action@v2
if: inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false
with:
sccache: s3
# with:
# sccache: s3
- uses: actions/checkout@v6
if: inputs.mode == 'pr'
with:
Expand Down
Loading