Fixes to big-endian bugs found in Curve448 and Blake2S#9778
Merged
dgarske merged 2 commits intowolfSSL:masterfrom Feb 16, 2026
Merged
Fixes to big-endian bugs found in Curve448 and Blake2S#9778dgarske merged 2 commits intowolfSSL:masterfrom
dgarske merged 2 commits intowolfSSL:masterfrom
Conversation
`wc_curve448_check_public` can get into an infinite loop in the big-endian code path.
We are copying from a 32bit buffer, so are overlapping writes. This could cause damage the hash on big-endian platforms.
SparkiDev
approved these changes
Feb 16, 2026
dgarske
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Blake2s overlapping writes
We are copying from a 32bit buffer, so are overlapping writes. This could cause damage the hash on big-endian platforms.
Fix curve448
wc_curve448_check_publiccan get into an infinite loop in the big-endian code path.