Skip to content

Fixes to big-endian bugs found in Curve448 and Blake2S #9778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgarske merged 2 commits into from
Feb 16, 2026
Merged

Fixes to big-endian bugs found in Curve448 and Blake2S #9778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
180c66b
Fix curve448
LinuxJedi Feb 16, 2026
451cb45
Fix Blake2s overlapping writes
LinuxJedi Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wolfcrypt/src/blake2s.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ int blake2s_final( blake2s_state *S, byte *out, byte outlen )
}

for( i = 0; i < 8; ++i ) /* Output full hash to temp buffer */
store64( buffer + sizeof( S->h[i] ) * i, S->h[i] );
store32( buffer + sizeof( S->h[i] ) * i, S->h[i] );

XMEMCPY( out, buffer, outlen );

Expand Down
4 changes: 2 additions & 2 deletions wolfcrypt/src/curve448.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,12 +409,12 @@ int wc_curve448_check_public(const byte* pub, word32 pubSz, int endian)
return ECC_BAD_ARG_E;
}
if ((i == 27) && (pub[i] == 0xfe)) {
for (++i; i < CURVE448_PUB_KEY_SIZE - 1; i--) {
for (++i; i < CURVE448_PUB_KEY_SIZE - 1; i++) {
if (pub[i] != 0xff) {
break;
}
}
if ((i == CURVE448_PUB_KEY_SIZE) && (pub[i] >= 0xfe)) {
if ((i == CURVE448_PUB_KEY_SIZE - 1) && (pub[i] >= 0xfe)) {
return ECC_BAD_ARG_E;
}
}
Expand Down