-
Notifications
You must be signed in to change notification settings - Fork 58
Upgrade GitHub runner image from Ubuntu 20.04 to 22.04 and modernize documentation #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com>
|
Also update README.md - Build section to have correct version, and target platform to have both. And any other changes in any other files. |
- Add Ubuntu 22.04 LTS to Build Environments table with GCC 11.x.x - Add Ubuntu 22.04.x LTS to Target Platforms table, marked as CI covered - Create docker/ubuntu22.04/Dockerfile for build consistency - Updated python to python3 in Ubuntu 22.04 Docker for compatibility Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com>
Updated README.md with Ubuntu 22.04 LTS information:
Commit: 20c54f4 |
| @@ -1,4 +1,4 @@ | |||
| name: C/C++ CI on Ubuntu 18:04 | |||
| name: C/C++ CI on Ubuntu 22.04 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 24?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu 22.04 LTS is the current stable LTS release with long-term support until 2027. Ubuntu 24.04 LTS was only released in April 2024 and may not have the same level of ecosystem stability and GitHub Actions runner support. For CI environments, it's generally better to use the established LTS version rather than the newest one to ensure compatibility and stability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have ubuntu-latest, which points to ubuntu 24. This PR just bumps for ubuntu 20 to ubuntu 22.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks!
docker/ubuntu22.04/Dockerfile
Outdated
|
|
||
| CMD /bin/bash | ||
|
|
||
| # ENTRYPOINT bash No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a blank line before the end of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added blank line at the end of the Dockerfile as requested.
reyang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use Ubuntu LTS 24?
Co-authored-by: reyang <17327289+reyang@users.noreply.github.com>
The README.md has been updated in commit 20c54f4 to include Ubuntu 22.04 LTS in both the Build Environments table (with GCC 11.x.x compiler) and Target Platforms table (marked as covered by CI). A Docker configuration for Ubuntu 22.04 has also been added. All references have been updated appropriately.
Ubuntu 22.04 LTS is the current stable LTS release with long-term support until 2027. Ubuntu 24.04 LTS was only released in April 2024 and may not have the same level of ecosystem stability and GitHub Actions runner support. For CI environments, it's generally better to use the established LTS version rather than the newest one to ensure compatibility and stability. We can consider upgrading to 24.04 LTS in the future once it has matured in the CI ecosystem. |
|
@copilot, please remove the reference of ubuntu 18 from the supported and build environment in README.md. |
Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com>
|
@copilot - In fact, remove all older ubuntu version support below 20.04. We only support ubuntu 20.04 and later. |
Co-authored-by: lalitb <1196320+lalitb@users.noreply.github.com>
Removed all Ubuntu versions below 20.04 from both Build Environments and Target Platforms tables in README.md. The documentation now only supports Ubuntu 20.04 and later versions. Commit: 8ef4aef |
mkoscumb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR upgrades the GitHub Actions workflow to use Ubuntu 22.04 instead of the deprecated Ubuntu 20.04 runner image and updates documentation to reflect current supported platforms.
Changes Made
.github/workflows/build-ubuntu-2004.yml→.github/workflows/build-ubuntu-2204.ymlubuntu-20.04toubuntu-22.04in the build matrixdocker/ubuntu22.04/Dockerfilefor build consistencyBenefits
The workflow will continue to run the same build and test processes, but now on the more recent and supported Ubuntu 22.04 platform.
Fixes #1361.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.