Skip to content

Upgrade GitHub runner image from Ubuntu 20.04 to 22.04 and modernize documentation #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lalitb merged 8 commits into from
Jul 29, 2025
Merged

Upgrade GitHub runner image from Ubuntu 20.04 to 22.04 and modernize documentation #1362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bc29f95
Initial plan
Copilot Jul 26, 2025
9b0e5e2
Upgrade GitHub runner from Ubuntu 20.04 to 22.04
Copilot Jul 26, 2025
20c54f4
Update README.md and add Ubuntu 22.04 Docker support
Copilot Jul 26, 2025
7001041
Merge branch 'main' into copilot/fix-1361
lalitb Jul 28, 2025
bbafd15
Merge branch 'main' into copilot/fix-1361
lalitb Jul 29, 2025
61094db
Add blank line at end of Dockerfile per review feedback
Copilot Jul 29, 2025
5074bf9
Remove Ubuntu 18.04 LTS references from README.md
Copilot Jul 29, 2025
8ef4aef
Remove Ubuntu versions below 20.04 from README.md as requested
Copilot Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-ubuntu-2004.yml → .github/workflows/build-ubuntu-2204.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: C/C++ CI on Ubuntu 18:04
name: C/C++ CI on Ubuntu 22.04
Copy link
Member

@reyang reyang Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 24?

Copy link
Contributor Author

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu 22.04 LTS is the current stable LTS release with long-term support until 2027. Ubuntu 24.04 LTS was only released in April 2024 and may not have the same level of ecosystem stability and GitHub Actions runner support. For CI environments, it's generally better to use the established LTS version rather than the newest one to ensure compatibility and stability.

Copy link
Contributor

@lalitb lalitb Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have ubuntu-latest, which points to ubuntu 24. This PR just bumps for ubuntu 20 to ubuntu 22.

Copy link
Member

@reyang reyang Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks!


on:
push:
Expand Down Expand Up @@ -28,11 +28,11 @@ jobs:
strategy:
matrix:
config: [release, debug]
os: [ubuntu-20.04]
os: [ubuntu-22.04]

steps:
- name: Checkout
uses: actions/checkout@v1
continue-on-error: true
- name: Test ${{ matrix.os }} ${{ matrix.config }}
run: ./build-tests.sh ${{ matrix.config }}
run: ./build-tests.sh ${{ matrix.config }}
8 changes: 2 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,7 @@ Other resources to learn how to setup the build system:
| Mac OS X 10.12.6 | Clang Xcode 9.0, 9.1 |
| Mac OS X 10.13.3 | Clang Xcode 9.2, 9.3, 10.0, 10.1 |
| Raspbian GNU/Linux 8 (jessie) | GCC 4.9.2 (armv7l) |
| Ubuntu 14.04.x LTS | GCC 5.x.x |
| Ubuntu 16.04 LTS | GCC 5.x.x, GCC 5.x.x (armv7l) |
| Ubuntu 18.04 LTS | GCC 7.5.x |
| Ubuntu 22.04 LTS | GCC 11.x.x |
| Windows 10 | Android Studio/Gradle |
| Windows Server 2016 | Visual Studio 2017 (vc141) |
| Windows Server 2022 | Visual Studio 2022 (vc143) |
Expand All @@ -86,10 +84,8 @@ Other resources to learn how to setup the build system:
| Linux (x86, x64, arm, aarch64) | :white_check_mark: | |
| Mac OS X 10.11+ | :white_check_mark: | |
| Mac OS X (latest) | :white_check_mark: | :white_check_mark: |
| Ubuntu 14.04.x LTS | :white_check_mark: | |
| Ubuntu 16.04.x LTS | :white_check_mark: | |
| Ubuntu 18.04.x LTS | :white_check_mark: | |
| Ubuntu 20.04.x LTS | :white_check_mark: | :white_check_mark: |
| Ubuntu 22.04.x LTS | :white_check_mark: | :white_check_mark: |
| Ubuntu (latest) | :white_check_mark: | :white_check_mark: |
| Windows 7.1 | :white_check_mark: | |
| Windows 8.1 | :white_check_mark: | |
Expand Down
22 changes: 22 additions & 0 deletions docker/ubuntu22.04/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
FROM ubuntu:22.04

ENV DEBIAN_FRONTEND noninteractive

# Package installation
RUN apt-get update

## Common packages for linux build environment
RUN apt install -y clang python3 pkg-config git curl nghttp2 bzip2 unzip make wget cmake sudo

RUN adduser --disabled-password --gecos '' docker
RUN adduser docker sudo
RUN echo '%sudo ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers
## RUN useradd -m docker && echo "docker:docker" | chpasswd && adduser docker sudo
## USER docker

# this is where I was running into problems with the other approaches
RUN sudo apt-get update

CMD /bin/bash

# ENTRYPOINT bash
Loading