gh-140739: Fix missing exception on allocation failure in BinaryWriter #143204
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yWriter The binary_writer_create function had several error paths where memory allocation failures would return NULL without setting a Python exception. This violated the C API contract and caused "returning an error without exception set" errors when BinaryWriter initialization failed due to memory pressure. Added PyErr_NoMemory calls before each goto error for PyMem_Malloc and _Py_hashtable_new_full failures. Neither of these functions set exceptions on failure, so callers must do it explicitly. The error label only performs cleanup and returns NULL, relying on exceptions being set beforehand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binary_writer_create function had several error paths where memory
allocation failures would return NULL without setting a Python exception.
This violated the C API contract and caused "returning an error without
exception set" errors when BinaryWriter initialization failed due to
memory pressure.
Added PyErr_NoMemory calls before each goto error for PyMem_Malloc and
_Py_hashtable_new_full failures. Neither of these functions set exceptions
on failure, so callers must do it explicitly. The error label only performs
cleanup and returns NULL, relying on exceptions being set beforehand.