Skip to content

gh-140739: Fix missing exception on allocation failure in BinaryWriter #143204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 1 commit into from
Dec 27, 2025
+7 −0
Merged

gh-140739: Fix missing exception on allocation failure in BinaryWriter #143204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Modules/_remote_debugging/binary_io_writer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,6 +741,7 @@ binary_writer_create(const char *filename, uint64_t sample_interval_us, int comp

writer->write_buffer = PyMem_Malloc(WRITE_BUFFER_SIZE);
if (!writer->write_buffer) {
PyErr_NoMemory();
goto error;
}
writer->buffer_size = WRITE_BUFFER_SIZE;
Expand All @@ -753,14 +754,17 @@ binary_writer_create(const char *filename, uint64_t sample_interval_us, int comp
NULL /* Use default allocator */
);
if (!writer->string_hash) {
PyErr_NoMemory();
goto error;
}
writer->strings = PyMem_Malloc(INITIAL_STRING_CAPACITY * sizeof(char *));
if (!writer->strings) {
PyErr_NoMemory();
goto error;
}
writer->string_lengths = PyMem_Malloc(INITIAL_STRING_CAPACITY * sizeof(size_t));
if (!writer->string_lengths) {
PyErr_NoMemory();
goto error;
}
writer->string_capacity = INITIAL_STRING_CAPACITY;
Expand All @@ -773,16 +777,19 @@ binary_writer_create(const char *filename, uint64_t sample_interval_us, int comp
NULL /* Use default allocator */
);
if (!writer->frame_hash) {
PyErr_NoMemory();
goto error;
}
writer->frame_entries = PyMem_Malloc(INITIAL_FRAME_CAPACITY * sizeof(FrameEntry));
if (!writer->frame_entries) {
PyErr_NoMemory();
goto error;
}
writer->frame_capacity = INITIAL_FRAME_CAPACITY;

writer->thread_entries = PyMem_Malloc(INITIAL_THREAD_CAPACITY * sizeof(ThreadEntry));
if (!writer->thread_entries) {
PyErr_NoMemory();
goto error;
}
writer->thread_capacity = INITIAL_THREAD_CAPACITY;
Expand Down
Loading