[Dep] Update to php 8.1 requirement by samsonasik · Pull Request #1364 · rectorphp/rector-src

samsonasik · 2021-12-02T03:28:22Z

No description provided.

samsonasik · 2021-12-02T03:34:04Z

it seems #[\ReturnTypeWillChange] attributerequired at :

PHP Deprecated:  Return type of Stringy\Stringy::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/rector-src/rector-src/vendor/danielstjules/stringy/src/Stringy.php on line 270
Deprecated: Return type of Stringy\Stringy::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/rector-src/rector-src/vendor/danielstjules/stringy/src/Stringy.php on line 270
PHP Deprecated:  Return type of Stringy\Stringy::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/rector-src/rector-src/vendor/danielstjules/stringy/src/Stringy.php on line 453
Deprecated: Return type of Stringy\Stringy::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/rector-src/rector-src/vendor/danielstjules/stringy/src/Stringy.php on line 453
PHP Deprecated:  Return type of Stringy\Stringy::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/rector-src/rector-src/vendor/danielstjules/stringy/src/Stringy.php on line 850
Deprecated: Return type of Stringy\Stringy::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/rector-src/rector-src/vendor/danielstjules/stringy/src/Stringy.php on line 850
PHP Deprecated:  Return type of Stringy\Stringy::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/rector-src/rector-src/vendor/danielstjules/stringy/src/Stringy.php on line 873
Deprecated: Return type of Stringy\Stringy::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/rector-src/rector-src/vendor/danielstjules/stringy/src/Stringy.php on line 873
PHP Deprecated:  Return type of Stringy\Stringy::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/rector-src/rector-src/vendor/danielstjules/stringy/src/Stringy.php on line 893
Deprecated: Return type of Stringy\Stringy::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/rector-src/rector-src/vendor/danielstjules/stringy/src/Stringy.php on line 893
PHP Deprecated:  Return type of Stringy\Stringy::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/rector-src/rector-src/vendor/danielstjules/stringy/src/Stringy.php on line 906
Deprecated: Return type of Stringy\Stringy::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/runner/work/rector-src/rector-src/vendor/danielstjules/stringy/src/Stringy.php on line 906

samsonasik · 2021-12-02T03:36:25Z

Also there are errors:

ERROR] Could not process                                                      
         "packages/PHPStanStaticTypeMapper/TypeMapper/CallableTypeMapper.php"   
         file, due to:                                                          
         "Rector\Core\PhpParser\ClassLikeAstResolver::resolveClassFromClassRefle
         ction(): Return value must be of type                                  
         PhpParser\Node\Stmt\Trait_|PhpParser\Node\Stmt\Class_|PhpParser\Node\St
         mt\Interface_|null, PhpParser\Node\Stmt\Enum_ returned". On line: 70   
                                                                                

                                                                                
 [ERROR] Could not process                                                      
         "packages/PHPStanStaticTypeMapper/TypeMapper/ClosureTypeMapper.php"    
         file, due to:                                                          
         "Rector\Core\PhpParser\ClassLikeAstResolver::resolveClassFromClassRefle
         ction(): Return value must be of type                                  
         PhpParser\Node\Stmt\Trait_|PhpParser\Node\Stmt\Class_|PhpParser\Node\St
         mt\Interface_|null, PhpParser\Node\Stmt\Enum_ returned". On line: 41   
                                                                                

                                                                                
 [ERROR] Could not process                                                      
         "packages/PHPStanStaticTypeMapper/TypeMapper/NeverTypeMapper.php" file,
         due to:                                                                
         "Rector\Core\PhpParser\ClassLikeAstResolver::resolveClassFromClassRefle
         ction(): Return value must be of type                                  
         PhpParser\Node\Stmt\Trait_|PhpParser\Node\Stmt\Class_|PhpParser\Node\St
         mt\Interface_|null, PhpParser\Node\Stmt\Enum_ returned". On line: 41   
                                                                                

                                                                                
 [ERROR] Could not process                                                      
         "packages/PHPStanStaticTypeMapper/TypeMapper/NullTypeMapper.php" file, 
         due to:                                                                
         "Rector\Core\PhpParser\ClassLikeAstResolver::resolveClassFromClassRefle
         ction(): Return value must be of type                                  
         PhpParser\Node\Stmt\Trait_|PhpParser\Node\Stmt\Class_|PhpParser\Node\St
         mt\Interface_|null, PhpParser\Node\Stmt\Enum_ returned". On line: 41

samsonasik · 2021-12-02T03:41:05Z

I added Enum_ return to ClassLikeAstResolver::resolveClassFromClassReflection()

samsonasik · 2021-12-02T04:04:41Z

rectify seems cause error in phpunit https://github.com/rectorphp/rector-src/pull/1364/files#diff-4dc6b2e58922af67eeb5d15d229c3b540f5ba436383dc4ff2b506c3bfd1ffaf8 :

1s
Run vendor/bin/phpunit
PHPUnit 9.5.10 by Sebastian Bergmann and contributors.

PHP Fatal error:  Case REFACTORING of non-backed enum Rector\Core\Enum\ApplicationPhase must not have a value, try adding ": string" to the enum declaration in /home/runner/work/rector-src/rector-src/vendor/rector/rector-src/src/Enum/ApplicationPhase.php on line 12
Error: Process completed with exit code 255.

samsonasik · 2021-12-02T04:14:19Z

There is also error on readonly param with no type:

.EFE....PHP Fatal error:  Readonly property Rector\Caching\ValueObject\CacheItem::$data must have type in /Users/samsonasik/www/rector-src/packages/Caching/ValueObject/CacheItem.php on line 16

Fatal error: Readonly property Rector\Caching\ValueObject\CacheItem::$data must have type in /Users/samsonasik/www/rector-src/packages/Caching/ValueObject/CacheItem.php on line 16

samsonasik · 2021-12-02T07:37:42Z

rebased.

samsonasik · 2021-12-02T08:13:38Z

@TomasVotruba I think Enum syntax upgrade needs to be skipped as it change PhpVersion class that extends :

use MyCLabs\Enum\Enum;

- final class PhpVersion extends Enum
+ enum PhpVersion : int

which will need update currently manually of its usage:

-PhpVersion::PHP_52;
+PhpVersion::PHP_52->value;

and it seems cause change

also other Enums, eg ObjectReference and ApplicationPhase manually:

-        if ($node->toString() === ObjectReference::PARENT()->getValue()) {
+        if ($node->toString() === ObjectReference::PARENT()->value) {

-        }, ApplicationPhase::PARSING());
+        }, ApplicationPhase::PARSING->value);

and we need to create a downgrade rule for it to keep working on scoping.

I commented the rules at 6ea553c

samsonasik · 2021-12-02T08:23:28Z

It seems readonly rule make error:

1) Rector\Tests\BetterPhpDocParser\PhpDocInlineHtml\TestInlineHtmlTest::test with data set #0 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Error: Cannot modify readonly property Rector\Core\PhpParser\Node\CustomNode\FileWithoutNamespace::$stmts

/home/runner/work/rector-src/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:111
/home/runner/work/rector-src/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223
/home/runner/work/rector-src/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:91
/home/runner/work/rector-src/rector-src/src/PhpParser/NodeTraverser/RectorNodeTraverser.php:41
/home/runner/work/rector-src/rector-src/src/Application/FileProcessor.php:43
/home/runner/work/rector-src/rector-src/src/Application/FileProcessor/PhpFileProcessor.php:107
/home/runner/work/rector-src/rector-src/src/Application/FileProcessor/PhpFileProcessor.php:122
/home/runner/work/rector-src/rector-src/src/Application/FileProcessor/PhpFileProcessor.php:108
/home/runner/work/rector-src/rector-src/src/Application/FileProcessor/PhpFileProcessor.php:61
/home/runner/work/rector-src/rector-src/src/Application/ApplicationFileProcessor.php:59
/home/runner/work/rector-src/rector-src/src/Application/ApplicationFileProcessor.php:36
/home/runner/work/rector-src/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:177
/home/runner/work/rector-src/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:131
/home/runner/work/rector-src/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:115
/home/runner/work/rector-src/rector-src/packages-tests/BetterPhpDocParser/PhpDocInlineHtml/TestInlineHtmlTest.php:18

Also it seems there is diff change on PhpDocInfoPrinter:

There were 55 failures:

1) Rector\Tests\BetterPhpDocParser\PhpDocInfo\PhpDocInfoPrinter\DoctrineTest::testClass with data set #0 ('/home/runner/work/rector-src/...le.txt', PhpParser\Node\Stmt\Class_ Object (...))
packages-tests/BetterPhpDocParser/PhpDocInfo/PhpDocInfoPrinter/Source/Doctrine/index_in_table.txt
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 '/**
- * @ORM\Table(
- *     name="building",
- *     indexes={
- *          @ORM\Index(name="isDemoBuilding", columns={"is_demo_building"})

/home/runner/work/rector-src/rector-src/packages-tests/BetterPhpDocParser/PhpDocParser/TagValueNodeReprint/TagValueNodeReprintTest.php:99
/home/runner/work/rector-src/rector-src/packages-tests/BetterPhpDocParser/PhpDocParser/TagValueNodeReprint/TagValueNodeReprintTest.php:57

53) Rector\Tests\BetterPhpDocParser\PhpDocParser\TagValueNodeReprint\TagValueNodeReprintTest::test with data set #50 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 '/**
-     * @ORM\JoinTable(name="PushCampaignCluster", joinColumns={
-     *      @ORM\JoinColumn(name="pushCampaignId", referencedColumnName="id")
-     * })
+ * @ORM\JoinTable(name="PushCampaignCluster", joinColumns={(name="pushCampaignId", referencedColumnName="id")})
      */'

/home/runner/work/rector-src/rector-src/packages-tests/BetterPhpDocParser/PhpDocParser/TagValueNodeReprint/TagValueNodeReprintTest.php:99
/home/runner/work/rector-src/rector-src/packages-tests/BetterPhpDocParser/PhpDocParser/TagValueNodeReprint/TagValueNodeReprintTest.php:57

54) Rector\Tests\BetterPhpDocParser\PhpDocParser\TagValueNodeReprint\TagValueNodeReprintTest::test with data set #51 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 '/**
-     * @ORM\JoinTable(name="page_template_area",
-     *      joinColumns={@ORM\JoinColumn(name="template_id", referencedColumnName="id", onDelete="CASCADE")},
-     *      inverseJoinColumns={@ORM\JoinColumn(name="area_id", referencedColumnName="id")}
-     * )
+ * @ORM\JoinTable(name="page_template_area", joinColumns={(name="template_id", referencedColumnName="id", onDelete="CASCADE")}, inverseJoinColumns={(name="area_id", referencedColumnName="id")})
      */'

/home/runner/work/rector-src/rector-src/packages-tests/BetterPhpDocParser/PhpDocParser/TagValueNodeReprint/TagValueNodeReprintTest.php:99
/home/runner/work/rector-src/rector-src/packages-tests/BetterPhpDocParser/PhpDocParser/TagValueNodeReprint/TagValueNodeReprintTest.php:57

55) Rector\Tests\BetterPhpDocParser\PhpDocParser\TagValueNodeReprint\TestModifyReprintTest::test
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 '/**
  * @Route("/hello/", methods={"GET", "HEAD"})
-     * @Template("some_path")
+ * @Template("some_path")
      */'

samsonasik · 2021-12-02T10:55:33Z

rebased.

samsonasik · 2021-12-02T11:09:44Z

I updated danielstjules/stringy to use fork while wait for PR danielstjules/Stringy#208 to be merged.

samsonasik · 2021-12-02T11:20:04Z

1 more error:

Run bin/rector process rules --ansi --no-progress-bar
  bin/rector process rules --ansi --no-progress-bar
  shell: /usr/bin/bash -e {0}
  env:
    COMPOSER_ROOT_VERSION: dev-main

In UnionTypeMapper.php line 137:
                                                                               
  Look at "Rector\PHPStanStaticTypeMapper\TypeMapper\UnionTypeMapper::mapToPh  
  pParserNode()" on line 137

samsonasik · 2021-12-02T11:20:48Z

debug output:

    [applying] Rector\CodeQuality\Rector\PropertyFetch\ExplicitMethodCallOverMagicGetSetRector

In UnionTypeMapper.php line 137:
                                                                                                         
  [Rector\Core\Exception\ShouldNotHappenException]                                                       
  Look at "Rector\PHPStanStaticTypeMapper\TypeMapper\UnionTypeMapper::mapToPhpParserNode()" on line 137  
                                                                                                         

Exception trace:
  at /Users/samsonasik/www/rector-src/packages/PHPStanStaticTypeMapper/TypeMapper/UnionTypeMapper.php:137
 Rector\PHPStanStaticTypeMapper\TypeMapper\UnionTypeMapper->mapToPhpParserNode() at /Users/samsonasik/www/rector-src/packages/PHPStanStaticTypeMapper/PHPStanStaticTypeMapper.php:56
 Rector\PHPStanStaticTypeMapper\PHPStanStaticTypeMapper->mapToPhpParserNode() at /Users/samsonasik/www/rector-src/packages/StaticTypeMapper/StaticTypeMapper.php:53
 Rector\StaticTypeMapper\StaticTypeMapper->mapPHPStanTypeToPhpParserNode() at /Users/samsonasik/www/rector-src/rules/TypeDeclaration/TypeAlreadyAddedChecker/ReturnTypeAlreadyAddedChecker.php:56
 Rector\TypeDeclaration\TypeAlreadyAddedChecker\ReturnTypeAlreadyAddedChecker->isSameOrBetterReturnTypeAlreadyAdded() at /Users/samsonasik/www/rector-src/rules/TypeDeclaration/Rector/FunctionLike/ReturnTypeDeclarationRector.php:113
 Rector\TypeDeclaration\Rector\FunctionLike\ReturnTypeDeclarationRector->refactor() at /Users/samsonasik/www/rector-src/src/Rector/AbstractRector.php:232
 Rector\Core\Rector\AbstractRector->enterNode() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:200
 PhpParser\NodeTraverser->traverseArray() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114
 PhpParser\NodeTraverser->traverseNode() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223
 PhpParser\NodeTraverser->traverseArray() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:114
 PhpParser\NodeTraverser->traverseNode() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:223
 PhpParser\NodeTraverser->traverseArray() at /Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:91
 PhpParser\NodeTraverser->traverse() at /Users/samsonasik/www/rector-src/src/PhpParser/NodeTraverser/RectorNodeTraverser.php:44
 Rector\Core\PhpParser\NodeTraverser\RectorNodeTraverser->traverse() at /Users/samsonasik/www/rector-src/src/Application/FileProcessor.php:43
 Rector\Core\Application\FileProcessor->refactor() at /Users/samsonasik/www/rector-src/src/Application/FileProcessor/PhpFileProcessor.php:107
 Rector\Core\Application\FileProcessor\PhpFileProcessor->Rector\Core\Application\FileProcessor\{closure}() at /Users/samsonasik/www/rector-src/src/Application/FileProcessor/PhpFileProcessor.php:122
 Rector\Core\Application\FileProcessor\PhpFileProcessor->tryCatchWrapper() at /Users/samsonasik/www/rector-src/src/Application/FileProcessor/PhpFileProcessor.php:108
 Rector\Core\Application\FileProcessor\PhpFileProcessor->refactorNodesWithRectors() at /Users/samsonasik/www/rector-src/src/Application/FileProcessor/PhpFileProcessor.php:61
 Rector\Core\Application\FileProcessor\PhpFileProcessor->process() at /Users/samsonasik/www/rector-src/src/Application/ApplicationFileProcessor.php:59
 Rector\Core\Application\ApplicationFileProcessor->processFiles() at /Users/samsonasik/www/rector-src/src/Application/ApplicationFileProcessor.php:36
 Rector\Core\Application\ApplicationFileProcessor->run() at /Users/samsonasik/www/rector-src/src/Console/Command/ProcessCommand.php:115
 Rector\Core\Console\Command\ProcessCommand->execute() at /Users/samsonasik/www/rector-src/vendor/symfony/console/Command/Command.php:298
 Symfony\Component\Console\Command\Command->run() at /Users/samsonasik/www/rector-src/vendor/symfony/console/Application.php:1005
 Symfony\Component\Console\Application->doRunCommand() at /Users/samsonasik/www/rector-src/vendor/symfony/console/Application.php:299
 Symfony\Component\Console\Application->doRun() at /Users/samsonasik/www/rector-src/src/Console/ConsoleApplication.php:79
 Rector\Core\Console\ConsoleApplication->doRun() at /Users/samsonasik/www/rector-src/vendor/symfony/console/Application.php:171
 Symfony\Component\Console\Application->run() at /Users/samsonasik/www/rector-src/bin/rector.php:71
 require_once() at /Users/samsonasik/www/rector-src/bin/rector:4

process [-o|--output-format [OUTPUT-FORMAT]] [-n|--dry-run] [-a|--autoload-file AUTOLOAD-FILE] [--no-progress-bar] [--no-diffs] [--clear-cache] [--port PORT] [--identifier IDENTIFIER] [--] [<source>...]

samsonasik · 2021-12-02T11:25:38Z

handled with ComplexType handling cf0c256

samsonasik · 2021-12-02T11:43:21Z

Using Stringy fork sometime seems cause composer install error:

                                                                                                              
  [RuntimeException]                                                                                          
  Failed to clone 
https://github.com/samsonasik/Stringy
 via https, ssh protocols, aborting.                   
                                                                                                              
  - 
https://github.com/samsonasik/Stringy
                                                                     
    Cloning into bare repository '/home/runner/.cache/composer/vcs/https---github.com-samsonasik-Stringy'...  
    BUG: refs/files-backend.c:2992: initial ref transaction called with existing refs                         
    Aborted (core dumped)

samsonasik · 2021-12-02T12:19:26Z

I updated stringy with vendor-patches

samsonasik · 2021-12-02T12:35:10Z

@TomasVotruba All green 🎉 , there are pending status workflow that I can't found in the workflows list, are they cache?

PHP 8.0 tests for packages-tests Expected — Waiting for status to be reported
Required
PHP 8.0 tests for rules-tests Expected — Waiting for status to be reported
Required
PHP 8.0 tests for tests Expected — Waiting for status to be reported

samsonasik · 2021-12-02T13:18:28Z

I tried downgrade script locally from php 8.1 and it seems got error on scoping:

[NOTE] Running scoper to rector-prefixed-downgraded

SSL_INIT
SSL_INIT
PHP Deprecated:  Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/samsonasik/www/rector-src/php-scoper.phar/.box/src/RequirementCollection.php on line 15

Deprecated: Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/samsonasik/www/rector-src/php-scoper.phar/.box/src/RequirementCollection.php on line 15
PHP Deprecated:  Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/samsonasik/www/rector-src/php-scoper.phar/.box/src/RequirementCollection.php on line 19

Deprecated: Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/samsonasik/www/rector-src/php-scoper.phar/.box/src/RequirementCollection.php on line 19
PHP Fatal error:  During inheritance of IteratorAggregate: Uncaught ErrorException: Return type of _HumbugBox016dd6921859\Symfony\Component\Finder\Finder::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/samsonasik/www/rector-src/php-scoper.phar/vendor/symfony/finder/Finder.php:219
Stack trace:
#0 phar:///Users/samsonasik/www/rector-src/php-scoper.phar/vendor/symfony/finder/Finder.php(16): _HumbugBox016dd6921859\Humbug\PhpScoper\{closure}(8192, 'Return type of ...', 'phar:///Users/s...', 219)
#1 phar:///Users/samsonasik/www/rector-src/php-scoper.phar/.box/vendor/composer/ClassLoader.php(444): include('phar:///Users/s...')
#2 phar:///Users/samsonasik/www/rector-src/php-scoper.phar/.box/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('phar:///Users/s...')
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass('_HumbugBox016dd...')
#4 phar:///Users/samsonasik/www/rector-src/php-scoper.phar/bin/php-scoper(42): class_alias('_HumbugBox016dd...', 'Isolated\\Symfon...')
#5 /Users/samsonasik/www/rector-src/php-scoper.phar(19): require('phar:///Users/s...')
#6 {main} in phar:///Users/samsonasik/www/rector-src/php-scoper.phar/vendor/symfony/finder/Finder.php on line 16

Fatal error: During inheritance of IteratorAggregate: Uncaught ErrorException: Return type of _HumbugBox016dd6921859\Symfony\Component\Finder\Finder::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///Users/samsonasik/www/rector-src/php-scoper.phar/vendor/symfony/finder/Finder.php:219
Stack trace:
#0 phar:///Users/samsonasik/www/rector-src/php-scoper.phar/vendor/symfony/finder/Finder.php(16): _HumbugBox016dd6921859\Humbug\PhpScoper\{closure}(8192, 'Return type of ...', 'phar:///Users/s...', 219)
#1 phar:///Users/samsonasik/www/rector-src/php-scoper.phar/.box/vendor/composer/ClassLoader.php(444): include('phar:///Users/s...')
#2 phar:///Users/samsonasik/www/rector-src/php-scoper.phar/.box/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('phar:///Users/s...')
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass('_HumbugBox016dd...')
#4 phar:///Users/samsonasik/www/rector-src/php-scoper.phar/bin/php-scoper(42): class_alias('_HumbugBox016dd...', 'Isolated\\Symfon...')
#5 /Users/samsonasik/www/rector-src/php-scoper.phar(19): require('phar:///Users/s...')
#6 {main} in phar:///Users/samsonasik/www/rector-src/php-scoper.phar/vendor/symfony/finder/Finder.php on line 16

@TomasVotruba do you think we need to use php 8.0 on build scoped as the scoper is inside php-scoper.phar phar file.

rector-src/.github/workflows/build_scoped_rector.yaml

Line 38 in 922e91d

php-version: 8.0

samsonasik · 2021-12-02T13:27:28Z

@TomasVotruba I set php to 8.0 on build scoped due #[\ReturnTypeWillChange] required inside php-scoper.phar when running on php 8.1, ref #1364 (comment)

samsonasik · 2021-12-03T07:11:09Z

@TomasVotruba rebased, I think it is ready for merge.

samsonasik · 2021-12-04T06:08:21Z

rebased.

samsonasik · 2021-12-04T07:50:20Z

rebased.

TomasVotruba · 2021-12-04T07:55:19Z

It's still too huge.
Could you decouple the non-Rectify code to standalone PR?

And another PR can be just about readonly properties. It's better to send PR-per single rule, in case it's huge.

samsonasik · 2021-12-04T08:09:00Z

It mostly a rectify PR, the manual part mostly phpstan on string array key unpack.

I will try to do enable php-81 config per-service on different PR (comment one by one).

samsonasik · 2021-12-04T12:38:36Z

rebased.

…s syntax update usage and downgrade rule for it

…r.phar

…nfig set, but skip in rector.php

samsonasik · 2021-12-04T13:07:02Z

rebased.

samsonasik · 2021-12-04T13:39:19Z

@TomasVotruba I think the rest of change mostly on finalize public constant, I think this PR can be merged instead of other per-service rule PRs.

samsonasik · 2021-12-04T15:46:16Z

Enabling the rest (except the Enum rectors), seems this is ready.

samsonasik mentioned this pull request Dec 2, 2021

[WIP] Bumping to PHP 8.1 #1316

Closed

This was referenced Dec 2, 2021

[Php81] Skip no type param on ReadOnlyPropertyRector #1365

Merged

[Php81] Add scalar type on Enum MyCLabsClassToEnumRector and SpatieEnumClassToEnumRector #1366

Merged

samsonasik force-pushed the tv-php81-2 branch from 2e40830 to acb3ad4 Compare December 2, 2021 07:37

samsonasik force-pushed the tv-php81-2 branch from a1b223a to 6ea553c Compare December 2, 2021 08:12

samsonasik mentioned this pull request Dec 2, 2021

[Php81] Skip non private modifier on ReadOnlyPropertyRector #1367

Merged

samsonasik force-pushed the tv-php81-2 branch from edd5d91 to 9bb7746 Compare December 2, 2021 10:55

samsonasik force-pushed the tv-php81-2 branch from bad7dd5 to 919c18b Compare December 2, 2021 11:41

samsonasik force-pushed the tv-php81-2 branch from b2e5a80 to f963e98 Compare December 2, 2021 12:03

samsonasik mentioned this pull request Dec 3, 2021

[Php 8.1 Dep] Update stringy vendor patches to update with #[\ReturnTypeWillChange] #1370

Merged

samsonasik force-pushed the tv-php81-2 branch from dfe3413 to ea1ad5d Compare December 3, 2021 07:10

samsonasik force-pushed the tv-php81-2 branch from 08f70ae to b5286e0 Compare December 4, 2021 06:08

samsonasik force-pushed the tv-php81-2 branch from e195c04 to ca435dc Compare December 4, 2021 07:50

samsonasik mentioned this pull request Dec 4, 2021

[Rectify] [Php81] Enable Rectify for finalize public class constant only #1380

Merged

samsonasik force-pushed the tv-php81-2 branch from b3c3abd to 170f083 Compare December 4, 2021 12:36

samsonasik and others added 12 commits December 4, 2021 20:04

skip MyCLabsClassToEnumRector and SpatieEnumClassToEnumRector as need…

bdf2aef

…s syntax update usage and downgrade rule for it

[ci-review] Rector Rectify

945c4eb

[ci-review] Rector Rectify

fb8b3f1

udpate danielstjules/stringy to use fork

b8242f9

use no-api true to fix error Could not authenticate against github.com

751761f

[ci-review] Rector Rectify

6108565

try update fork url

e711caf

update stringy with vendor-patches

d0e65bc

set php 8.0 on build scoped due #[\ReturnTypeWillChange] on php-scope…

7decf49

…r.phar

enable MyCLabsClassToEnumRector and SpatieEnumClassToEnumRector in co…

39f158a

…nfig set, but skip in rector.php

downgrade from php 8.1, scoping from php 8.0

b9f0cde

clean rector.php

982c544

samsonasik force-pushed the tv-php81-2 branch from 1a07c04 to 982c544 Compare December 4, 2021 13:06

samsonasik and others added 2 commits December 4, 2021 22:44

Merge branch 'main' into tv-php81-2

7c16833

[ci-review] Rector Rectify

17908e3

samsonasik enabled auto-merge (squash) December 4, 2021 15:48

samsonasik merged commit 5d1f96f into main Dec 4, 2021

samsonasik deleted the tv-php81-2 branch December 4, 2021 15:50

Uh oh!

Conversation

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021

Uh oh!

samsonasik commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samsonasik commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samsonasik commented Dec 3, 2021

Uh oh!

samsonasik commented Dec 4, 2021

Uh oh!

samsonasik commented Dec 4, 2021

Uh oh!

TomasVotruba commented Dec 4, 2021

Uh oh!

samsonasik commented Dec 4, 2021

Uh oh!

samsonasik commented Dec 4, 2021

Uh oh!

samsonasik commented Dec 4, 2021

Uh oh!

samsonasik commented Dec 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samsonasik commented Dec 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

samsonasik commented Dec 2, 2021 •

edited

Loading

samsonasik commented Dec 2, 2021 •

edited

Loading

samsonasik commented Dec 2, 2021 •

edited

Loading

samsonasik commented Dec 4, 2021 •

edited

Loading